Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clear and apply commands #74

Merged
merged 19 commits into from
Aug 17, 2023
Merged

Add clear and apply commands #74

merged 19 commits into from
Aug 17, 2023

Conversation

danielsinai
Copy link
Collaborator

@danielsinai danielsinai commented Aug 13, 2023 •
edited
Loading

Description

What - Added ocean defaults group, included ocean defaults dock and ocean defaults clean commands
Why - Easier way to test the Ocean framework when developing an integration
How - Added a new CLI group

Type of change

Please leave one option from the following and delete the rest:

  • New feature (non-breaking change which adds functionality)

Cheatsheet

# apply defaults from the .port/resources folder
ocean defaults dock 

# clean defaults (only blueprints) asynchronously
ocean defaults clean

# clean defaults with blueprints + entities
ocean defaults clean --force true

# clean defaults with bluerpints entities and wait for the migration to finish
ocean defaults clean --force true --wait true

yairsimantov20
yairsimantov20 reviewed Aug 13, 2023
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
port_ocean/cli/commands/defaults/clean.py Show resolved Hide resolved
port_ocean/cli/defaults/clean.py Outdated Show resolved Hide resolved
port_ocean/clients/port/mixins/migrations.py Outdated Show resolved Hide resolved
port_ocean/clients/port/mixins/migrations.py Show resolved Hide resolved
port_ocean/clients/port/mixins/migrations.py Outdated Show resolved Hide resolved
port_ocean/run.py Show resolved Hide resolved
port_ocean/run.py Outdated Show resolved Hide resolved
@yairsimantov20
Copy link
Collaborator

in run.py move _create_default_app & _get_base_integration_class_from_module to bootstrap.py (u can change the to public if needed)

_load_module move to utils.py

yairsimantov20
yairsimantov20 approved these changes Aug 17, 2023
View reviewed changes
Copy link
Collaborator

@yairsimantov20 yairsimantov20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌊 LGTM

changelog/dock-clean-defaults.feature.md Outdated
@@ -0,0 +1 @@
Added the abillity to clean and create the defaults of an integration
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just make sure to show that to @MPTG94

@danielsinai danielsinai merged commit bea8a5b into main Aug 17, 2023
1 check passed
@danielsinai danielsinai deleted the add-clear-and-apply-commands branch August 17, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yairsimantov20 yairsimantov20 yairsimantov20 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielsinai @yairsimantov20